Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key and certfile to request options for helix-front calls to helix-rest #2672

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add key and certfile to request options for helix-front calls to helix-rest #2672

merged 1 commit into from
Oct 19, 2023
+8 −0

Conversation

GrantPSpencer
Copy link
Contributor

Issues

HTTPS helix-rest endpoints not working for helix-front

Description

Was not able to get HTTPS requests to helix-rest to work without also passing the cert and key in the request options.

Tests

Deployed locally

cd pathToRepo/helix-front
yarn build
yarn start

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@GrantPSpencer GrantPSpencer changed the title Add key and certfile to request options for helix-rest calls Add key and certfile to request options for helix-front calls to helix-rest Oct 18, 2023
@GrantPSpencer
Copy link
Contributor Author

@hivivo Hi Vivo, would you be willing to take a look at this PR? I saw that you built helix-front and would appreciate your expertise

hivivo
hivivo approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@hivivo hivivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thank you for adding this!

@hivivo hivivo merged commit 937d506 into apache:master Oct 19, 2023
3 checks passed
@GrantPSpencer GrantPSpencer mentioned this pull request Oct 20, 2023
Merged
2 tasks
zpinto pushed a commit to zpinto/helix that referenced this pull request Nov 8, 2023
@GrantPSpencer @zpinto
add keyfile and certfile to request options (apache#2672)
d3aebea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hivivo hivivo hivivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrantPSpencer @hivivo